bans-minecraft/utamacraft
bans-minecraft/utamacraft
2
0
Fork 2
Code Issues 20 Pull Requests Packages Projects 1 Releases 14 Wiki Activity

Migrate to minecraft 1.20 #70

Merged
BlakeRain merged 1 commits from BlakeRain/utamacraft:main into main 2024-02-11 17:02:40 +00:00
Conversation 0 Commits 1 Files Changed 38 +321 -252
BlakeRain commented 2024-02-11 17:02:31 +00:00
Owner
Copy Link

Terrifying migration of the mod to Minecraft v1.20.1. There are a few things I'm not entirely happy about:

  1. I had to remove the consumer() call from the message builder in ModMessages for DumpInsolatorFluidPacket, which means that the message sent when the dump button is pressed in the Insolator UI, the server won't handle the message. I'm not sure where I can adequately handle the mesage now, so a new issues has been created to track this: #69
  2. In our insolator recipies the getResultItem() method takes a RegistryAccess, but I'm not sure where to get one. In the JEI and the block entity I'm just using null for now, which is probably not ideal.
  3. In the InsolatorScreen we used to have tooltips on the dump button. Now there's nothing.
Terrifying migration of the mod to Minecraft v1.20.1. There are a few things I'm not entirely happy about: 1. I had to remove the `consumer()` call from the message builder in `ModMessages` for `DumpInsolatorFluidPacket`, which means that the message sent when the dump button is pressed in the Insolator UI, the server won't handle the message. I'm not sure where I can adequately handle the mesage now, so a new issues has been created to track this: #69 2. In our insolator recipies the `getResultItem()` method takes a `RegistryAccess`, but I'm not sure where to get one. In the JEI and the block entity I'm just using `null` for now, which is probably not ideal. 3. In the `InsolatorScreen` we used to have tooltips on the dump button. Now there's nothing.
BlakeRain added the
Kind/Enhancement
 label 2024-02-11 17:02:31 +00:00
BlakeRain self-assigned this 2024-02-11 17:02:31 +00:00
BlakeRain added 1 commit 2024-02-11 17:02:32 +00:00
BlakeRain merged commit f0225c4c8c into main 2024-02-11 17:02:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Focus/Block Entities

Relates to the block entities in the mod

  
Focus/Blocks

Relates to generic blocks in the mod (not block entities or ores)

  
Focus/CC

Relates to ComputerCraft inetgration in the mod

  
Focus/Effects

Relates to effects granted by items in the mod

  
Focus/Forge

Relates to Forge integration of the mod

  
Focus/Ores

Relates to the ores in the mod

  
Focus/Recipes

Relates to the recipes in the mod

  
Focus/Rendering

Relates to rendering in the mod

  
Focus/Texturing

Issues relates the the texturing in the mod

  
Focus/UI

Relates the the mod UI

  
Focus/Wiki

Relates to the modpack wiki

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Focus/Block Entities
Focus/Blocks
Focus/CC
Focus/Effects
Focus/Forge
Focus/Ores
Focus/Recipes
Focus/Rendering
Focus/Texturing
Focus/UI
Focus/Wiki
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
BlakeRain
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: bans-minecraft/utamacraft#70
No description provided.
Delete Branch "BlakeRain/utamacraft:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?