Bulb location in Insolator UI is broken #36

New Issue

BlakeRain · 2023-12-05T18:25:24Z

BlakeRain commented

2023-12-05 18:25:24 +00:00

The location of the lit bulb when running the Insolator with the new UI is in the wrong location (see attachment).

CleanShot 2023-12-05 at 18.07.29.png

11 KiB

BlakeRain added this to the v0.3.0-1.20.1 milestone 2023-12-05 18:25:24 +00:00

BlakeRain added the

Priority

Medium

Kind/Bug

labels 2023-12-05 18:25:24 +00:00

BlakeRain self-assigned this 2023-12-05 18:25:24 +00:00

BlakeRain added this to the Mod Development project 2023-12-05 18:25:24 +00:00

BlakeRain commented

2023-12-06 13:14:28 +00:00

The coordinates given in the code for the InsolatorScreen::renderBulb function are incorrect:

private void renderBulb(PoseStack stack) {
    if (menu.getBlockEntity().getActive()) {
        blit(stack, leftPos + 67, topPos + 38, 176, 25, 9, 14);
    }
}

The coordinates, according to Affinity are 133 and 37 (not 67 and 38).

The coordinates given in the [code](https://git.blakerain.com/bans-minecraft/utamacraft/src/commit/a40288fe7804b9a3825b16ff2e707930a7570172/src/main/java/net/banutama/utamacraft/screen/InsolatorScreen.java#L142) for the `InsolatorScreen::renderBulb` function are incorrect: ```java private void renderBulb(PoseStack stack) { if (menu.getBlockEntity().getActive()) { blit(stack, leftPos + 67, topPos + 38, 176, 25, 9, 14); } } ``` The coordinates, according to Affinity are 133 and 37 (not 67 and 38).

BlakeRain added the

Focus/UI

label 2023-12-17 10:30:34 +00:00

BlakeRain referenced this issue from a commit

2023-12-17 11:32:27 +00:00

fix: position of the bulb in the insolator UI (fixes #36)

BlakeRain closed this issue

2023-12-17 11:32:27 +00:00

Sign in to join this conversation.