BlakeRain/parcel

Fork 0

WIP: Add tags to uploads #38

Draft

BlakeRain wants to merge 11 commits from 17-tags into main

BlakeRain commented

2026-03-27 13:10:29 +00:00

Owner

This PR closes #17 by adding support for tags on each upload. Each upload can have any number of tags, and uploads can be filtered by tags. Tags are kept around in a tags table with unique names over users and teams. Autocomplete in the tag editor is provided using a <datalist>.

There are a few things left to do:

The filter UI is present, but doesn't have any effect on the upload list yet.
I haven't added any tests for the UI.
The user settings page needs to include a section where a user can edit their tags.

This PR closes #17 by adding support for tags on each upload. Each upload can have any number of tags, and uploads can be filtered by tags. Tags are kept around in a `tags` table with unique names over users and teams. Autocomplete in the tag editor is provided using a `<datalist>`. There are a few things left to do: - [ ] The filter UI is present, but doesn't have any effect on the upload list yet. - [ ] I haven't added any tests for the UI. - [ ] The user settings page needs to include a section where a user can edit their tags.

BlakeRain added the

Kind

Feature

label

2026-03-27 13:10:29 +00:00

BlakeRain self-assigned this

2026-03-27 13:10:29 +00:00

BlakeRain added 11 commits

2026-03-27 13:10:29 +00:00

feat: add upload tags cd19a0833d

fix: remove unused functions 02e9861f4b

feat: add filter UI for tags b4695ddada

fix: issues after rebase cf193f2332

fix: ambiguity in E2E test bd5d88b815

fix: rename migration script 010bec55d0

fix: unknown problem with .pattern and make tag RE unicode aware 9a7a2f4dd6

fix: duplicate registering of <parcel-dropdown> 8cc3a5a706

fix: add .invalid class for <input> elements ff7bfa72fb

fix: issue with conflicting Cypress selector 0e41127944

fix: rename migration to avoid conflict after rebase

Check / check (pull_request) Has been cancelled

Details

0270085a36

BlakeRain commented

2026-03-27 13:13:36 +00:00

Author

Owner

Progress on this has gone quite well. See the attached images.

There are a couple of problems that will need addressing:

I really like the <parcel-select> element, but it's not going to play nicely if we filter as users change the selection if that causes the list interface to reload. May need to consider something else.
When tags are added to uploads that are new, the select UI doesn't show the new tags in the filter list.

Progress on this has gone quite well. See the attached images. There are a couple of problems that will need addressing: 1. I really like the `<parcel-select>` element, but it's not going to play nicely if we filter as users change the selection if that causes the list interface to reload. May need to consider something else. 2. When tags are added to uploads that are new, the select UI doesn't show the new tags in the filter list.

469247735-6baf09dc-6d9d-405c-8680-4062479644ae.png

36 KiB

469247773-b89913ce-7fd4-4e69-bf4b-c2879ba67d96.png

27 KiB

469247811-469537e4-7f47-4111-839d-4b06d9d71494.png

33 KiB

469247846-e11a514f-2de9-4646-ae01-b2161b6b44cb.png

51 KiB

469247870-73e6a539-72a8-4e68-95e5-e0190368b143.png

21 KiB

BlakeRain referenced this pull request

2026-03-27 13:18:55 +00:00

Rebase all the PRs #39

BlakeRain added the

Status

Blocked

label

2026-03-27 13:37:01 +00:00

BlakeRain commented

2026-03-27 13:37:32 +00:00

Author

Owner

Blocked for #39

Check / check (pull_request) Has been cancelled

Details

This pull request is marked as a work in progress.

This branch is out-of-date with the base branch

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 17-tags:17-tags

git switch 17-tags

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff 17-tags

git switch 17-tags

git rebase main

git switch main

git merge --ff-only 17-tags

git switch 17-tags

git rebase main

git switch main

git merge --no-ff 17-tags

git switch main

git merge --squash 17-tags

git switch main

git merge --ff-only 17-tags

git switch main

git merge 17-tags

git push origin main

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

BlakeRain/parcel!38

No description provided.

Rows
Columns